Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev:di:info error #38747

Closed
wants to merge 1 commit into from
Closed

dev:di:info error #38747

wants to merge 1 commit into from

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented May 23, 2024

Description (*)

$paramsTable->render() not return anything (https://github.com/symfony/console/blob/v6.4.2/Helper/Table.php#L318).
It call $this->output->writeln for display table => not need $output->writeln in magento

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes dev:di:info error in magento 2.4.7 #38740

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented May 23, 2024

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rogerdz
Copy link
Contributor Author

rogerdz commented May 23, 2024

@magento run all tests

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label May 23, 2024
@rogerdz
Copy link
Contributor Author

rogerdz commented May 23, 2024

@magento run WebAPI Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@rogerdz
Copy link
Contributor Author

rogerdz commented May 24, 2024

@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jun 6, 2024
@engcom-Bravo
Copy link
Contributor

Hello,

Internal team has started to work on it

Thanks.

@hostep hostep mentioned this pull request Jun 26, 2024
1 task
@hostep
Copy link
Contributor

hostep commented Jul 3, 2024

For some reason, this PR wasn't marked as merged, even though the code was merged (cherry-picked?) recently here: c6d91bd

@engcom-Bravo
Copy link
Contributor

@hostep Thanks for your contribution!!.

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11999 by the internal team
Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11999&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P3 May be fixed according to the position in the backlog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev:di:info error in magento 2.4.7
3 participants