-
Notifications
You must be signed in to change notification settings - Fork 686
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
168 changed files
with
7,148 additions
and
3,867 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
packages/**/node_modules | ||
packages/**/dist |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
name: Documentation Request | ||
about: Help us improve the documentation | ||
title: "[doc]: A short, simple sentence describing the doc request" | ||
labels: documentation | ||
assignees: 'jcalcaben' | ||
--- | ||
|
||
<!-- | ||
Thank you for taking the time to report this issue! | ||
GitHub Issues should only be created for problems/topics related to this project's codebase. | ||
Before submitting this issue, please make sure you are complying with our Code of Conduct: | ||
https://github.com/magento-research/pwa-studio/blob/develop/.github/CODE_OF_CONDUCT.md | ||
Issues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion. | ||
Feel free to remove this section before creating this issue. | ||
--> | ||
|
||
**Describe the request** | ||
A clear and concise description of the documentation request or where the documentation can be improved. | ||
|
||
**Possible solutions** | ||
How would you word this addition or change? | ||
|
||
**Screenshots** | ||
If applicable, add screenshots to help explain the problem. | ||
|
||
<!-- Complete the following sections to help us apply appropriate labels! --> | ||
**Please let us know whether this is a new topic or a topic change request:** | ||
- [ ] New Topic Request (ie. missing entire topic/section) | ||
- [ ] Topic Change Request (ie. spelling, organization) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,54 +1,49 @@ | ||
<!-- | ||
Thank you for your contribution! | ||
Before submitting this pull request, please make sure you have read our Contribution Guidelines and your PR meets our contribution standards: | ||
https://github.com/magento-research/pwa-studio/blob/master/.github/CONTRIBUTION.md | ||
https://github.com/magento-research/pwa-studio/blob/master/.github/CONTRIBUTING.md | ||
Please fill out as much information as you can about your PR to help speed up the review process. | ||
If your PR addresses an existing GitHub Issue, please refer to it in the title or Additional Information section to make the connection. | ||
We may ask you for changes in your PR in order to meet the standards set in our Contribution Guidelines. PRs that do not comply with our guidelines may be closed at the maintainers' discretion. | ||
Feel free to remove this section before creating this PR. | ||
Feel free to remove this section before creating this PR. Thank you for your contribution! | ||
--> | ||
|
||
## Description | ||
<!--- Provide a general summary of your changes in the Title above --> | ||
<!--- Describe your changes in detail here: --> | ||
<!--- Describe your changes in detail here --> | ||
|
||
## Related Issue | ||
<!--- This project only accepts pull requests related to open issues --> | ||
<!--- If suggesting a new feature or change, please discuss it in an issue first --> | ||
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> | ||
<!--- Please link to the issue here with the specific wording: "Closes #<issue>" --> | ||
<!--- Using the above wording causes Github to automatically close the issue on merge. --> | ||
Closes #ISSUENUM. | ||
Closes #ISSUE_NUMBER. | ||
|
||
## Motivation and Context | ||
<!--- Why is this change required? What problem does it solve? --> | ||
## Verification Steps | ||
<!-- Please describe in detail how a reviewer can verify your changes. --> | ||
1. Go to the FOO page. | ||
2. Verify the BAR shows up. | ||
3. Make sure BAZ does a thing. | ||
|
||
## How Has This Been Tested? | ||
## How Have YOU Tested this? | ||
<!--- Please describe in detail how you tested your changes. --> | ||
<!--- Include details of your testing environment, and the tests you ran to --> | ||
<!--- see how your change affects other areas of the code, etc. --> | ||
|
||
## Screenshots (if appropriate): | ||
## Screenshots / Screen Captures (if appropriate): | ||
|
||
## Proposed Labels for Change Type/Package | ||
<!--- What types of changes does your code introduce? Let us know if this is a --> | ||
<!--- BUG, FEATURE, DOCUMENTATION, or TEST change. --> | ||
|
||
<!--- What packages are modified by this code? Let us know if this applies to --> | ||
<!--- peregrine, pwa-buildpack, upward-js, upward-spec, venia-concept or pwa-devdocs --> | ||
<!--- What type of change level would you suggest for this PR? --> | ||
<!--- Major, Minor, or Patch? --> | ||
<!--- See https://magento-research.github.io/pwa-studio/technologies/versioning/ for help --> | ||
- [ ] major (e.g x.0.0 - a breaking change) | ||
- [ ] minor (e.g 0.x.0 - a backwards compatible addition) | ||
- [ ] patch (e.g 0.0.x - a bug fix) | ||
|
||
## Checklist: | ||
<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
- [ ] I have read the **CONTRIBUTING** document. | ||
- [ ] I have linked an issue to this PR. | ||
- [ ] I have indicated the change type and relevant package(s). | ||
- [ ] I have updated the documentation accordingly. | ||
- [ ] I have added tests to cover my changes. | ||
- [ ] All new and existing tests passed. | ||
- [ ] All CI checks are green (linting, build/deploy, etc). | ||
- [ ] At least one core contributor has approved this PR. | ||
- [ ] I have updated the documentation accordingly, if necessary. | ||
- [ ] I have added tests to cover my changes, if necessary. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
save-prefix="~" | ||
save-prefix="^" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
save-prefix "~" | ||
save-prefix "^" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.