Block magepack during 'generate' command (#151)

magesuite · Oct 24, 2022 · 8dd9400 · 8dd9400
1 parent d874da3
commit 8dd9400
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 0 deletions.
diff --git a/lib/generate/blockMagepack.js b/lib/generate/blockMagepack.js
@@ -0,0 +1,22 @@
+const logger = require('../utils/logger');
+
+/**
+ * @param {Page} page Puppeteer Page object instance.
+ */
+const blockMagepack = (page) => {
+    page.setRequestInterception(true);
+    page.on('request', (request) => {
+        const url = request.url();
+
+        // If we let these resources load, 'magepack generate' hangs at rjsResolver step.
+        if (url.match(/magepack\/requirejs-config-.*\.js$/)) {
+            logger.info('Blocked resource: ' + url);
+            request.abort();
+            return;
+        }
+
+        request.continue();
+    });
+};
+
+module.exports = blockMagepack;
diff --git a/lib/generate/collector/category.js b/lib/generate/collector/category.js
@@ -2,6 +2,7 @@ const merge = require('lodash.merge');
 
 const logger = require('../../utils/logger');
 const authenticate = require('../authenticate');
+const blockMagepack = require('../blockMagepack');
 const collectModules = require('../collectModules');
 
 const baseConfig = {
@@ -31,6 +32,8 @@ const category = async (
 
     const page = await browserContext.newPage();
 
+    blockMagepack(page);
+
     await authenticate(page, authUsername, authPassword);
 
     await page.goto(categoryUrl, {

diff --git a/lib/generate/collector/checkout.js b/lib/generate/collector/checkout.js
@@ -4,6 +4,7 @@ const merge = require('lodash.merge');
 
 const logger = require('../../utils/logger');
 const authenticate = require('../authenticate');
+const blockMagepack = require('../blockMagepack');
 const collectModules = require('../collectModules');
 
 const baseConfig = {
@@ -33,6 +34,8 @@ const checkout = async (
 
     const page = await browserContext.newPage();
 
+    blockMagepack(page);
+
     await authenticate(page, authUsername, authPassword);
 
     await page.goto(productUrl, { waitUntil: 'networkidle0' });

diff --git a/lib/generate/collector/cms.js b/lib/generate/collector/cms.js
@@ -2,6 +2,7 @@ const merge = require('lodash.merge');
 
 const logger = require('../../utils/logger');
 const authenticate = require('../authenticate');
+const blockMagepack = require('../blockMagepack');
 const collectModules = require('../collectModules');
 
 const baseConfig = {
@@ -28,6 +29,8 @@ const cms = async (browserContext, { cmsUrl, authUsername, authPassword }) => {
 
     const page = await browserContext.newPage();
 
+    blockMagepack(page);
+
     await authenticate(page, authUsername, authPassword);
 
     await page.goto(cmsUrl, { waitUntil: 'networkidle0' });

diff --git a/lib/generate/collector/product.js b/lib/generate/collector/product.js
@@ -2,6 +2,7 @@ const merge = require('lodash.merge');
 
 const logger = require('../../utils/logger');
 const authenticate = require('../authenticate');
+const blockMagepack = require('../blockMagepack');
 const collectModules = require('../collectModules');
 
 const baseConfig = {
@@ -31,6 +32,8 @@ const product = async (
 
     const page = await browserContext.newPage();
 
+    blockMagepack(page);
+
     await authenticate(page, authUsername, authPassword);
 
     await page.goto(productUrl, { waitUntil: 'networkidle0' });