Handle URLs without scheme #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists currently special handling for URLs that begin with
http://andhttps://, but not for URLs that begin with//(ie, which have no scheme). When magepack encounters a URL such as//unpkg.com/jqueryit does not recognise this as an external asset. This pull request adds handling for the scheme-less URL format.While I think it's better to always include a scheme, it is technically valid and has been suggested / recommended by some to omit the scheme. Without a scheme specified, the user agent will use the scheme of the current document, so a
http://page parsing//www.example.net/will result inhttp://www.example.net/, and ahttps://page parsing//www.example.org/will result inhttps://www.example.org/.