Skip to content

Commit

Permalink
Minor code changes
Browse files Browse the repository at this point in the history
  • Loading branch information
@nikolakisae
nikolakisae committed Mar 10, 2024
1 parent 9ab21dd commit 8b5bc3c
Show file tree
Hide file tree
Showing 16 changed files with 27 additions and 60 deletions.
7 changes: 2 additions & 5 deletions Block/Adminhtml/System/Config/Info.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
declare(strict_types=1);
Expand All @@ -21,10 +21,7 @@

class Info extends AbstractBlock implements RendererInterface
{
/**
* @var ExtensionInfo
*/
protected $info;
protected ExtensionInfo $info;

/**
* @param Context $context
Expand Down
32 changes: 7 additions & 25 deletions Controller/Adminhtml/Email/MassSend.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
declare(strict_types=1);
Expand All @@ -29,35 +29,17 @@

class MassSend extends Action
{
/**
* @var Filter
*/
protected $filter;
protected Filter $filter;

/**
* @var salesCollectionFactory
*/
protected $salesCollectionFactory;
protected SalesCollectionFactory $salesCollectionFactory;

/**
* @var CustomerCollectionFactory
*/
protected $customerCollectionFactory;
protected CustomerCollectionFactory $customerCollectionFactory;

/**
* @var Config
*/
protected $config;
protected Config $config;

/**
* @var TransportBuilder
*/
protected $transportBuilder;
protected TransportBuilder $transportBuilder;

/**
* @var StateInterface
*/
protected $inlineTranslation;
protected StateInterface $inlineTranslation;

/**
* @param Context $context
Expand Down
7 changes: 2 additions & 5 deletions Model/Config.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
declare(strict_types=1);
Expand All @@ -20,10 +20,7 @@ class Config
const XML_PATH_EMAIL_SENDER = 'massemailcustomers/email/identity';
const XML_PATH_EMAIL_TEMPLATE = 'massemailcustomers/email/template';

/**
* @var ScopeConfigInterface
*/
protected $scopeConfig;
protected ScopeConfigInterface $scopeConfig;

/**
* @param ScopeConfigInterface $scopeConfig
Expand Down
17 changes: 4 additions & 13 deletions Model/Info.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @package MageVision_MassEmailCustomers
*
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
declare(strict_types=1);
Expand All @@ -22,20 +22,11 @@ class Info
{
const MODULE_NAME = 'Mass Email Customers';

/**
* @var DriverInterface
*/
protected $driver;
protected DriverInterface $driver;

/**
* @var Json
*/
protected $serializer;
protected Json $serializer;

/**
* @var Reader
*/
protected $reader;
protected Reader $reader;

/**
* @param DriverInterface $driver
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"magento/module-sales": "103.0.*"
},
"type": "magento2-module",
"version": "2.4.2",
"version": "2.4.3",
"license": [
"OSL-3.0",
"AFL-3.0"
Expand Down
2 changes: 1 addition & 1 deletion etc/acl.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/adminhtml/di.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/adminhtml/routes.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/adminhtml/system.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/config.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/email_templates.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion registration.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/

Expand Down
2 changes: 1 addition & 1 deletion view/adminhtml/ui_component/customer_listing.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion view/adminhtml/ui_component/sales_order_grid.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down
2 changes: 1 addition & 1 deletion view/frontend/email/mass_email_customers.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @category MageVision
* @package MageVision_MassEmailCustomers
* @author MageVision Team
* @copyright Copyright (c) 2023 MageVision (https://www.magevision.com)
* @copyright Copyright (c) 2024 MageVision (https://www.magevision.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-->
Expand Down

0 comments on commit 8b5bc3c

Please sign in to comment.