feat: run linting before build and deploy

Closes #9
mainawycliffe · Dec 26, 2022 · 4f649b8 · 4f649b8
1 parent cb0b7c0
commit 4f649b8
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/packages/firebase/src/generators/functions/utilities/addProjectorConfigs.ts b/packages/firebase/src/generators/functions/utilities/addProjectorConfigs.ts
@@ -10,17 +10,6 @@ export default function addProjectConfigs(
     projectType: 'library',
     sourceRoot: `${normalizedOptions.projectRoot}/src`,
     targets: {
-      build: {
-        executor: '@nrwl/js:tsc',
-        options: {
-          outputPath: `dist/${normalizedOptions.projectRoot}`,
-          tsConfig: `${normalizedOptions.projectRoot}/tsconfig.json`,
-          main: `${normalizedOptions.projectDirectory}/src/index.ts`,
-        },
-      },
-      serve: {
-        executor: '@nx-toolkits/firebase:serve',
-      },
       lint: {
         executor: '@nrwl/linter:eslint',
         outputs: ['{options.outputFile}'],
@@ -29,9 +18,22 @@ export default function addProjectConfigs(
           fix: true,
         },
       },
+      // todo: will circle back to this later
+      // serve: {
+      //   executor: '@nx-toolkits/firebase:serve',
+      // },
+      build: {
+        executor: '@nrwl/js:tsc',
+        dependsOn: ['lint'],
+        options: {
+          outputPath: `dist/${normalizedOptions.projectRoot}`,
+          tsConfig: `${normalizedOptions.projectRoot}/tsconfig.json`,
+          main: `${normalizedOptions.projectDirectory}/src/index.ts`,
+        },
+      },
       deploy: {
         executor: '@nx-toolkits/firebase:deploy',
-        dependsOn: ['build', 'lint'],
+        dependsOn: ['build'],
       },
     },
     tags: normalizedOptions.parsedTags,