chore(typescript): ember-simple-auth initial setup #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobrImperator
force-pushed
the
typescript
branch
5 times, most recently
from
bc1ec6b to
7728e82
Compare
BobrImperator
force-pushed
the
typescript
branch
from
7728e82 to
611170e
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peerDependencyonember-source >= 4.0so the ember-source types are included correctly.This is potentially 💥 as pnpm will not allow to install it on lower versions.
It's fine though, I've been looking to drop
classic-test-appand older ember versions anyway since the broad compatibility testing is increasingly harder to satisfy.