Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ember-simple-auth): parse expirationTime before setting it #2891

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Dec 28, 2024

  • Fixes setting NaN as an expiration time.

@BobrImperator BobrImperator force-pushed the fix-parse-expiration-time branch from 09b938b to 0f14b68 Compare December 28, 2024 19:04
Copy link

github-actions bot commented Dec 28, 2024

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-beta

  • test-app test:one ember-canary

  • test-app test:one ember-beta

  • classic-test-app test:one ember-canary

    Created by continue-on-error-comment

Copy link

github-actions bot commented Dec 28, 2024

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-beta

  • classic-test-app test:one ember-canary

  • test-app test:one ember-canary

  • test-app test:one ember-beta

    Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit 6f86a3d into master Dec 28, 2024
40 of 42 checks passed
@BobrImperator BobrImperator deleted the fix-parse-expiration-time branch December 28, 2024 19:06
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant