Remove AccountLayout section, create SidebarMenu component #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jordanarldt
force-pushed
the
ja/add-sidebar-menu
branch
from
d3e3df5 to
72043bb
Compare
apps/web/vibes/soul/examples/sections/order-details-section/electric.tsx
Outdated
Show resolved
Hide resolved
jordanarldt
force-pushed
the
ja/add-sidebar-menu
branch
from
72043bb to
1fba1f2
Compare
github-actions
bot
dismissed stale reviews from jorgemoya and migueloller
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/makeswift/vibes/actions/runs/12933981322
migueloller
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountLayoutsection component, as it is basically just a very simple wrapper ofStickySidebarLayout. This can be simplified down with the newSidebarMenucomponentSidebarMenucomponent to have a unified component to use in theStickySidebarLayoutsidemenu propAccount Layoutexamples toSticky Sidebar Layout