Add currency form #472
Closed
Add currency form #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncs with bigcommerce/catalyst#1912
|
@bookernath is attempting to deploy a commit to the Makeswift Team on Vercel. A member of the Team first needs to authorize it. |
5 tasks
migueloller
requested changes
Jan 22, 2025
Comment on lines
+30
to
+31
| import { Link } from '~/components/link'; | ||
| import { usePathname } from '~/i18n/routing'; |
There was a problem hiding this comment.
These imports are Catalyst-only
| const activeCurrency = currencies.find((currency) => currency.id === activeCurrencyId); | ||
|
|
||
| useEffect(() => { | ||
| if (lastResult?.error) console.log(lastResult.error); |
There was a problem hiding this comment.
We should use alerts here together with useForm from conform to avoid reaching into lastResult which is meant to be opaque
|
closing so @jorgemoya can open a new one from a branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncs with bigcommerce/catalyst#1912