Fixed error when including theme. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did so by ignoring the `include` key in the `setColor` function.
|
Yikes, nice catch! Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a new theme for Amfora, I went to the theme page, I downloaded one and I used the
includekey to import it. I want to use theincludekey because it feels way more convenient than copy-pasting a theme in the configuration file.When the
includedirective was not under the[theme]tag, it was ignored, when theincludekey was under the[theme]tag, I got the following error:This PR make so that the theme parser ignores the
includekeys in order to prevent the error.