Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update to 0.9.1 #38

Merged
merged 11 commits into from
Dec 21, 2022
Merged

WIP: Update to 0.9.1 #38

merged 11 commits into from
Dec 21, 2022

Conversation

opfromthestart
Copy link
Contributor

Attempting to update everything to bevy 0.9.1, and thought that it should be pushed back into the original. Not everything works yet, and I can't test teal by myself.

@opfromthestart opfromthestart changed the title Update to 0.9.1 WIP: Update to 0.9.1 Dec 16, 2022
makspll
makspll requested changes Dec 17, 2022
View reviewed changes
Copy link
Owner

@makspll makspll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, aligns more or less with my unfinished migration experiment, just left a few comments on things I think might benefit a discussion/improvement!

Your PR is extremely appreciated!

makefile Outdated Show resolved Hide resolved
bevy_mod_scripting_core/src/lib.rs Outdated Show resolved Hide resolved
bevy_script_api/src/lua/util.rs Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
@makspll
Copy link
Owner

makspll commented Dec 17, 2022

Do run cargo clippy --features=lua54,rhai,teal,lua_script_api,rhai_script_api --fix as well please

@opfromthestart
Copy link
Contributor Author

I saw that you were attempting it through your post in the discord related to CachedScriptState, but didnt see a branch dedicated to it so just did all the changes here.

@opfromthestart
Fixed some requested things
4a99053 
Docs now partially work
project changed to package
unneeded reference removed
Resource moved to ScriptHost definition.
@makspll
Copy link
Owner

makspll commented Dec 19, 2022 •
edited
Loading

Oh I see, yeah I briefly experimented with the migration before life got in the way, I did not push these experiments to any branch, so your PR is very welcome!

Do let me know if any of these changes are too much and I'll take over them!

@opfromthestart
New path generator
03523c8
@opfromthestart
No type registry wrapper
d9fb30b
@opfromthestart
Kinda close to working
5f12086 
All the imports are actual paths, but the code that gets generated is wrong.
@opfromthestart
Generation now works
45b735c
@opfromthestart
Copy link
Contributor Author

I cannot test the game of life example, which is the only one which uses a camera, so I don't know if it is working correctly, but everything appears to work now.

@makspll makspll mentioned this pull request Dec 21, 2022
Closed
@makspll
Copy link
Owner

makspll commented Dec 21, 2022

All looks fantastic, game of life works :) I'll make some changes and then merge and hopefully release soon

@makspll makspll merged commit 2d0dfc0 into makspll:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makspll makspll makspll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opfromthestart @makspll