Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades 2023-09-04 #133

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Upgrades 2023-09-04 #133

merged 5 commits into from
Sep 5, 2023

Conversation

leehart
Copy link
Collaborator

@leehart leehart commented Sep 4, 2023

Resolves #132

@alimanfoo
Copy link
Member

OSX build failure looks fun to debug... this thread maybe relevant: mamba-org/mamba#1826

@leehart leehart force-pushed the GH132_update_malariagen-data branch 2 times, most recently from 6237e30 to 35156ca Compare September 5, 2023 08:46
@leehart leehart force-pushed the GH132_update_malariagen-data branch from 35156ca to 3dceeb9 Compare September 5, 2023 09:01
@leehart
Copy link
Collaborator Author

leehart commented Sep 5, 2023

Using conda-libmamba-solver seems to work, re: conda/conda#13041

alimanfoo
alimanfoo previously approved these changes Sep 5, 2023
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks @leehart 🙂

ahernank
ahernank previously approved these changes Sep 5, 2023
Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @leehart!

Very small nit, might be nice to include the version of conda-libmamba-solver used.

@leehart
Copy link
Collaborator Author

leehart commented Sep 5, 2023

Very small nit, might be nice to include the version of conda-libmamba-solver used.

Thanks @ahernank . I suppose we could just use the output of conda list conda-libmamba-solver, i.e.

# packages in environment at /foo/bar:
#
# Name                    Version                   Build  Channel
conda-libmamba-solver     23.7.0             pyhd8ed1ab_0    conda-forge

I don't know if there's a more specific way, akin to python --version?

@leehart
Copy link
Collaborator Author

leehart commented Sep 5, 2023

I don't know if there's a more specific way, akin to python --version?

I suppose we could extract the version number from conda list conda-libmamba-solver, but I fear this might be flaky / less robust:

conda list conda-libmamba-solver | awk '$1 == "conda-libmamba-solver" {print $2}'

@leehart leehart dismissed stale reviews from ahernank and alimanfoo via 64665aa September 5, 2023 17:47
@ahernank
Copy link
Collaborator

ahernank commented Sep 5, 2023

Yes, I don't think there is an easier way than parsing conda list, I thought it would be helpful for debugging but I now realize that the division on versions seems to function more like functional/experimental. Thanks for adding!

@ahernank ahernank self-requested a review September 5, 2023 18:05
@leehart leehart merged commit 4e3fe84 into master Sep 5, 2023
@leehart leehart deleted the GH132_update_malariagen-data branch September 5, 2023 18:24
@leehart leehart restored the GH132_update_malariagen-data branch May 2, 2024 15:43
@leehart leehart deleted the GH132_update_malariagen-data branch May 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade malariagen_data to >=7.13.0
3 participants