Changes to API #52
Merged
Changes to API #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
===========================================
+ Coverage 72.25% 82.77% +10.52%
===========================================
Files 10 9 -1
Lines 764 662 -102
===========================================
- Hits 552 548 -4
+ Misses 212 114 -98
☔ View full report in Codecov by Sentry. |
|
@ffevotte I think this is ready to be looked at (no pressure). The changes are conceptually simple, but a lot of code was modified in the process. Maybe we could also merge it first (all tests+docs are passing) and field-test it while implementing the other features? I am OK either way. |
|
Please merge it, thx! |
- Documenter 1.0 no longer uses the `strict` keyword
|
Congrats! |
|
I think this was mostly ready, but still requires some field testing. Let me know if you run into any issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main usage is now through the
DataFlowTasks.@spawnmacro, which works very much likeThreads.@spawn. In particular, it now returns aTaskand not aDataFlowTask.IMO this makes understanding and using the package easier.
Left to do:
TiledFactorizationto this new API