Expand discussion on nesting tasks and limitations #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start discussion on nesting of tasks
- when set to false, does not execute code - useful updating mostly the text of the docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 86.00% 80.86% -5.14%
==========================================
Files 9 9
Lines 686 690 +4
==========================================
- Hits 590 558 -32
- Misses 96 132 +36 ☔ View full report in Codecov by Sentry. |
maltezfaria
force-pushed
the
nested-dag
branch
from
d5e9a46 to
b1f2537
Compare
|
@ffevotte I think this is ready for a first review. I found it quite tricky to explain the problem with nested tasks, but I tried 😅 https://maltezfaria.github.io/DataFlowTasks.jl/previews/PR77/troubleshooting/#nested-tasks |
This was
linked to
issues
Nov 9, 2023
|
While I was at it, I also added a small suggested workflow section with the experience described in #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, but the idea is to explain a bit better the current limitations. In particular, why nesting is somewhat tricky, and what are the current workarounds. Maybe this will also help us decide on a proper way forward, such as the nesting of
TaskGraphs and merging ofLogInfoobjects.