Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract TiledFactorization module #8

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

maltezfaria
Copy link
Owner

  • Extract the TiledFactorization module into a package
  • Update the dependencies
  • Move tests on cholesky and lu to TiledFactorization

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #8 (0f57da6) into main (52ceae7) will increase coverage by 1.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   58.94%   60.91%   +1.96%     
==========================================
  Files          12        8       -4     
  Lines         609      481     -128     
==========================================
- Hits          359      293      -66     
+ Misses        250      188      -62     
Impacted Files Coverage Δ
src/DataFlowTasks.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ceae7...0f57da6. Read the comment docs.

@maltezfaria
Copy link
Owner Author

Partially addresses #5. The other issues mentioned there (careful benchmarking and reviving the lu solver) should be moved upstream to the TiledFactorization package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant