Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Tasks as a data-dependency in a DataFlowTask #80

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

maltezfaria
Copy link
Owner

An attempt to resolve #79.

handle `Task`s in the `data`

format
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c1b46e7) 86.08% compared to head (99f0f79) 80.31%.

Files Patch % Lines
src/dag.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   86.08%   80.31%   -5.78%     
==========================================
  Files           9        9              
  Lines         690      696       +6     
==========================================
- Hits          594      559      -35     
- Misses         96      137      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria maltezfaria merged commit 7744ef6 into main Nov 17, 2023
6 of 7 checks passed
@maltezfaria
Copy link
Owner Author

LGTM

@maltezfaria maltezfaria deleted the task-dependency branch November 17, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching inside a DataFlowTask
1 participant