-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatePicker be able to 'esc' to close #48
Comments
this stops the date picker handling the escape key as a close request requestClose(buttonClicked) {
if (!buttonClicked && this.props.modal) {
if the dialog is set to modal then you can't break out with an escape const modal = (container === 'inline' ? null : true);
|
UI guideline examples
|
The default behaviour is not for escape to cancel a dialog (see supporting documentation for this in issue #48). Added a new property to dialog to allow for escape to be disabled, so the old functionality can be enabled if required.
added top level disableDismissWithEscapeOnDialog property to date picker which cascades through date picker dialog to dialog so that the escape key can be disabled for dismissing the popup
Currently cannot hit Esc to close the window (even when focus is on it)
The text was updated successfully, but these errors were encountered: