Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSMF - playback continues after stop #333

Open
kfeinUI opened this issue Jul 8, 2015 · 5 comments
Open

OSMF - playback continues after stop #333

kfeinUI opened this issue Jul 8, 2015 · 5 comments
Labels

Comments

@kfeinUI
Copy link

kfeinUI commented Jul 8, 2015

  1. Load up a live HLS stream.
  2. Once playing, stop playback.

The output goes black for a moment, but then playback resumes. It appears to play through the remainder of the buffer.

  1. Hit play to restart playback.

It fails to play.

@mangui mangui added the OSMF label Jul 15, 2015
@mangui
Copy link
Owner

mangui commented Jul 15, 2015

@kfeinUI I commited some changes today that might affect this.
f59d942
could you recheck with latest flashls/dev.
if still repro, plz share debug logs
thanks,
Cheers,
Mangui

@kfeinUI
Copy link
Author

kfeinUI commented Jul 15, 2015

Thanks! Fixes the stopping issue.

What remains is that when you play again after having stopped. It appears to play off the remaining buffer. The expected behavior for a live stream is for it to do a fresh load so that you may watch the live playback.

@mangui
Copy link
Owner

mangui commented Jul 15, 2015

@kfeinUI
not clear about how you trigger stop ? through API means ? there is no stop button on GrindPlayer

@kfeinUI
Copy link
Author

kfeinUI commented Jul 15, 2015

Yes, through the API. Never mentioned using Grind. I'm using stock Strobe.

For live streams, we stop rather than pause.

On Wed, Jul 15, 2015 at 11:35 AM, Guillaume du Pontavice <
[email protected]> wrote:

@kfeinUI https://github.com/kfeinUI
not clear about how you trigger stop ? through API means ? there is no
stop button on GrindPlayer


Reply to this email directly or view it on GitHub
#333 (comment).

@mangui
Copy link
Owner

mangui commented Jul 15, 2015

ok. in fact the bug is that upon calling stop() the internal buffer is not flushed.
in theory you should not be able to playback the previously cached content after stop().
if you want to restart your live stream playback you should reload the whole stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants