-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add originator information to callback #20
Comments
Thank you for raising the issue with all the relevant details @vicdelfant . Let me check this and get back to you in ~2 Days |
Did a small POC using the Will create a branch and share a WIP PR by tomorrow EOD, that being said we may expect a new version to be made available by Monday post testing these changes for any potential issues. |
Nice! Thank you 🙏 Ping me here once the PR is ready and I’d be happy to test too. |
Quick question: Are you currently using this ? |
We actually are, yes. It's for an in-house app but it'll be an integral part of the operational side of things :) |
Oh, happy to hear that the library is helping solve a use case :D |
* Extract originating address, and return the same in an array along with message body * Update the peer dependency to 0.68.2 * Fix syntax error * Syntax fixes * Remove getUSerData * Change the return type of getMessageFromMessageIntent from String [] to String * Bump the package version to v1.1 * Update the readme.md
Great, thank you! 🙏 |
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Currently, the
startReadSMS
callback only receives the message body and not the sender's number. Having the sender information would make this library a lot more valuable because it can then be used to fully handle inbound text messages.Describe alternatives you've considered
None available, this library seems to be one of a kind in the Expo ecosystem :)
Additional context
The
getMessageFromMessageIntent
function only takes thegetDisplayMessageBody()
:react-native-expo-read-sms/android/src/main/java/com/reactlibrary/RNExpoReadSmsModule.java
Line 82 in ceb1eac
Using a structure for the
message
and returning thegetDisplayOriginatingAddress
could solve this, but I'm by no means enough of an Android developer to test this… unfortunately.The text was updated successfully, but these errors were encountered: