Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add originator information to callback #20

Closed
vicdelfant opened this issue Feb 20, 2023 · 8 comments · Fixed by #26
Closed

Add originator information to callback #20

vicdelfant opened this issue Feb 20, 2023 · 8 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@vicdelfant
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Currently, the startReadSMS callback only receives the message body and not the sender's number. Having the sender information would make this library a lot more valuable because it can then be used to fully handle inbound text messages.

Describe alternatives you've considered
None available, this library seems to be one of a kind in the Expo ecosystem :)

Additional context
The getMessageFromMessageIntent function only takes the getDisplayMessageBody():

Using a structure for the message and returning the getDisplayOriginatingAddress could solve this, but I'm by no means enough of an Android developer to test this… unfortunately.

@maniac-tech
Copy link
Owner

Thank you for raising the issue with all the relevant details @vicdelfant .

Let me check this and get back to you in ~2 Days

@maniac-tech maniac-tech added the enhancement New feature or request label Feb 20, 2023
@maniac-tech maniac-tech self-assigned this Feb 20, 2023
@maniac-tech
Copy link
Owner

Did a small POC using the getDisplayOriginatingAddress, and is working as expected.

Will create a branch and share a WIP PR by tomorrow EOD, that being said we may expect a new version to be made available by Monday post testing these changes for any potential issues.

@maniac-tech maniac-tech added the WIP This is currently being worked upon label Feb 22, 2023
@vicdelfant
Copy link
Author

Nice! Thank you 🙏 Ping me here once the PR is ready and I’d be happy to test too.

@maniac-tech
Copy link
Owner

Nice! Thank you 🙏 Ping me here once the PR is ready and I’d be happy to test too.

Quick question: Are you currently using this ?

@vicdelfant
Copy link
Author

We actually are, yes. It's for an in-house app but it'll be an integral part of the operational side of things :)

@maniac-tech maniac-tech linked a pull request Feb 23, 2023 that will close this issue
4 tasks
@maniac-tech
Copy link
Owner

Oh, happy to hear that the library is helping solve a use case :D

maniac-tech added a commit that referenced this issue Feb 26, 2023
* Extract originating address, and return the same in an array along with message body

* Update the peer dependency to 0.68.2

* Fix syntax error

* Syntax fixes

* Remove getUSerData

* Change the return type of getMessageFromMessageIntent from String [] to String

* Bump the package version to v1.1

* Update the readme.md
@maniac-tech maniac-tech removed the WIP This is currently being worked upon label Feb 26, 2023
@maniac-tech
Copy link
Owner

This has been fixed in the PR #26 , and the npm package has been deployed with a new version 1.1 .

@vicdelfant
Copy link
Author

Great, thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants