Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffersize to parameters #22

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Add buffersize to parameters #22

merged 3 commits into from
Aug 28, 2023

Conversation

chadek
Copy link
Contributor

@chadek chadek commented Aug 27, 2023

When I first try to retrieve data from my Axpert vm 3k plus I figured out that qpiri answer of my device was not 97 bytes, as set in this code but 98. So I used @ned-kelly code in this repo and manage to make a use of my device by playing with the buffer size parameters. I suggest to add these changes to the original code, adding default values.

I set qpiri buffer to 98 by default has it work for me but if 97 is a valid value for other type of devices, we can put it back to 97.

@manio manio merged commit f6f5849 into manio:master Aug 28, 2023
@manio
Copy link
Owner

manio commented Aug 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants