Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for PolarizationCorrectionsHelpers methods #38602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve test coverage for PolarizationCorrectionsHelpers methods #38602

wants to merge 1 commit into from
+78 −0

Conversation

yusufjimoh
Copy link
Contributor

Description of work

  • added unit tests to test splitSpinStateString
  • added unit tests to test indexOfWorkspaceForSpinState
  • added unit tests to test workSpaceForSpinState

Fixes #37749

To test:

  • review unit tests
  • tests should pass

This does not require release notes because it involves updating the unit tests

@yusufjimoh yusufjimoh linked an issue Jan 14, 2025 that may be closed by this pull request
Improve test coverage for PolarizationCorrectionsHelpers methods #37749
Open
@yusufjimoh yusufjimoh marked this pull request as ready for review January 17, 2025 09:18
@yusufjimoh yusufjimoh added Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Jan 17, 2025
@yusufjimoh yusufjimoh added this to the Release 6.13 milestone Jan 17, 2025
@rbauststfc rbauststfc self-assigned this Jan 17, 2025
rbauststfc
rbauststfc reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional test coverage here is really comprehensive and added in a way that should be easy to maintain.

I have just a few suggestions that might be worth considering.

Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h Show resolved Hide resolved
Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h Show resolved Hide resolved
Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h Show resolved Hide resolved
@yusufjimoh
- added helper methods to test methods in polAarization correction he…
f7cd3ee 
…lper methods

- added unit tests to splitSpinStateString
- added unit tests to test indexOfWorkspaceForSpinState
- added unit tests to test workSpaceForSpinState
@yusufjimoh yusufjimoh force-pushed the 37749-improve-test-coverage-for-polarizationcorrectionshelpers-methods branch from fd6a6f8 to f7cd3ee Compare January 22, 2025 20:23
@yusufjimoh yusufjimoh requested a review from rbauststfc January 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbauststfc rbauststfc Awaiting requested review from rbauststfc

At least 1 approving review is required to merge this pull request.

Assignees

@rbauststfc rbauststfc

Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS
Projects
ISIS LSS Sprint Planning
Status: Review
Milestone
Release 6.13
Development

Successfully merging this pull request may close these issues.

Improve test coverage for PolarizationCorrectionsHelpers methods
2 participants
@yusufjimoh @rbauststfc