Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Qt uses CSS-based stylesheets to specify widget properties. Rather than having SNAPRed use NO stylesheet when it's launched under Mantid workbench. The
SNAPRedGUI
will be assigned one of either "workbench_style.qss" or SNAPRed's normal "style.qss", depending on how the application is launched.Summary of work
Changes to the
SNAPRed.py
qt-interface file.Purpose of work
In order to centralize its widget property settings, the
SNAPRed
application now has required stylesheet values.EWM task #9132
Further detail of work
PR in support of SNAPRed's reduction live-data implementation: EWM#7437
To test:
Although anyone is welcome to review this PR, it would be easiest for a SNAPRed developer to review it!
mantidworkbench
directory of your existing recent "SNAPRed" environment).workbench_style.qss
will be used if it exists: copysrc/snapred/resources/style.qss
tosrc/snapred/resources/workbench_style.qss
in the SNAPRed environment you are using (which may be the "developer's installation).This does not require release notes because it is in support of SNAPRed internal changes.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.