Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNAPRed stylesheets #38670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNAPRed stylesheets #38670

wants to merge 1 commit into from

Conversation

ekapadi
Copy link
Contributor

@ekapadi ekapadi commented Jan 22, 2025

Description of work

Qt uses CSS-based stylesheets to specify widget properties.  Rather than having SNAPRed use NO stylesheet when it's launched under Mantid workbench.  The SNAPRedGUIwill be assigned one of either "workbench_style.qss" or SNAPRed's normal "style.qss", depending on how the application is launched.

Summary of work

Changes to the SNAPRed.py qt-interface file.

Purpose of work

In order to centralize its widget property settings, the SNAPRed application now has required stylesheet values.

EWM task #9132

Further detail of work

PR in support of SNAPRed's reduction live-data implementation: EWM#7437

To test:

Although anyone is welcome to review this PR, it would be easiest for a SNAPRed developer to review it!

  1. Either build Mantid and install the SNAPRed developer's environment (or move the single changed python file into its location in the mantidworkbench directory of your existing recent "SNAPRed" environment).
  2. Launch workbench, then launch SNAPRed. No changes should be observed in comparison to launching SNAPRed in its most recent conda environment.
  3. Verify that the workbench_style.qss will be used if it exists: copy src/snapred/resources/style.qss to src/snapred/resources/workbench_style.qss in the SNAPRed environment you are using (which may be the "developer's installation).
  4. Again launch workbench: now the super awesome SNAPRed color scheme will be used for the SNAPRed application (, although that has nothing to do with this PR :( ).

This does not require release notes because it is in support of SNAPRed internal changes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

  * Qt uses CSS-based stylesheets to specify widget properties.  Rather than having SNAPRed use NO stylesheet when it's launched under Mantid workbench.  The `SNAPRedGUI`will be assigned one of either "workbench_style.qss" or SNAPRed's normal "style.qss", depending on how the application is launched.
@ekapadi ekapadi added the ORNL Team Issues and pull requests managed by the ORNL development team label Jan 22, 2025
@ekapadi ekapadi added this to the Release 6.12 milestone Jan 22, 2025
@sf1919 sf1919 modified the milestones: Release 6.12, Release 6.13 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ORNL Team Issues and pull requests managed by the ORNL development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants