Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mantidworkbench as an entry point for the mantidworkbench Conda package - ornl-next #38686

Conversation

peterfpeterson
Copy link
Member

This is a version of #38559 and #38669 into ornl-next

jhaigh0 and others added 2 commits January 23, 2025 17:08
Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Thomas Hampson <[email protected]>

Add arg passing to workbench launch wrapper script

Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Thomas Hampson <[email protected]>

Add release notes

Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Thomas Hampson <[email protected]>

Update launch script name in linux standalone packaging script

Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Jonathan Haigh <[email protected]>

Change python exec command to avoid infinite loop when launching on Linux

Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Jonathan Haigh <[email protected]>

Fix name of mantid launch script in standalone package script

Co-authored-by: James Clarke <[email protected]>
Co-authored-by: Jonathan Haigh <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Move release notes to 6.12 folder

Add return code handling

Rename workbench_launch_wrapper to mantidworkbench_launch_wrapper

Rename standalone launcher script

Renamed from workbench_launcher_jemalloc to launch_mantidworkbench

Pass command-line arguments through to main

Co-authored-by: Pete Peterson <[email protected]>

Add optional argument to workbench main() and launch()

Then someone can pass in arguments directly instead of using
sys.argv. If no arguments are given then sys.argv gets used
by default.

Co-authored-by: Thomas Hampson <[email protected]>

add backticks to release notes

Co-authored-by: Caila Finn <[email protected]>
The first argument of sys.argv is the launch script, so
we don't need that.
@peterfpeterson peterfpeterson added the ornl-next A copy of a branch into the ornl-next fork label Jan 23, 2025
@peterfpeterson peterfpeterson merged commit 6bb3712 into mantidproject:ornl-next Jan 23, 2025
9 of 10 checks passed
@peterfpeterson peterfpeterson deleted the 38654_launch_script_in_editor_ornlnext branch January 23, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ornl-next A copy of a branch into the ornl-next fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants