Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu 'keepMounted' prevents tabbing in form #4502

Closed
elirandpg opened this issue Jul 5, 2023 · 5 comments
Closed

Menu 'keepMounted' prevents tabbing in form #4502

elirandpg opened this issue Jul 5, 2023 · 5 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@elirandpg
Copy link

What package has an issue

@mantine/core

Describe the bug

When having a Menu with the keepMounted attribute (for SEO purposes) on the same page with a form element, tabbing between form elements becomes non-responsive. Remove the keepMounted property, and tabbing goes back to normal.

What version of @mantine/hooks page do you have in package.json?

6.0.16

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/p/sandbox/cool-dan-kjddq6?file=%2Fsrc%2FApp.tsx%3A17%2C26

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

No response

@elirandpg
Copy link
Author

Is there anybody out there? 🎶

@rtivital
Copy link
Member

I've received your issue and examined your issue, it is in the common backlog queue. If you would rather not wait for the fix, you are welcome to submit a PR with a fix.

@elirandpg
Copy link
Author

Thank you, was really just looking for confirmation that it's in the pipeline on some level.

@rtivital rtivital added the TBD label Sep 25, 2023
@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed TBD labels Dec 4, 2023
@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@verdansk
Copy link

verdansk commented Jan 24, 2024

Unfortunately this issue is not resolved in v7.3.1 or later. When <Menu /> has the keepMounted-prop set, tabbing through the form, or tabbing in general becomes unresponsive.

I've updated the sandbox to the latest version, and migrated from 6 to 7.
https://codesandbox.io/p/devbox/eloquent-feynman-9rw9cw

Update
When you set the props trapFocus and withinPortal on the menu item this issue is resolved. Apologies for the confusion.

     <Menu
     keepMounted
     trapFocus={false}
     withinPortal={false}
     ....
     />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants