[@mantine/modals] Expose Modals Manager props #7189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case in my application where I needed to read from the Modals manager props, so I created this PR to allow them to be exposed to the user.
EDIT: I also discovered an error in my implementation of
updateContextModal
, which would throw the following error:hook.js:608 Warning: React does not recognize the `modalId` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `modalid` instead. If you accidentally passed it from a parent component, remove it from the DOM element. Error Component Stack
This occurred because the modalId was unintentionally included in the props passed to the modal component. I have resolved this in the PR by ensuring that modalId is excluded from the props spread onto the modal.