Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/modals] Expose Modals Manager props #7189

Merged

Conversation

pfo-omicsstudio
Copy link
Contributor

@pfo-omicsstudio pfo-omicsstudio commented Nov 29, 2024

I had a use case in my application where I needed to read from the Modals manager props, so I created this PR to allow them to be exposed to the user.

EDIT: I also discovered an error in my implementation of updateContextModal, which would throw the following error:
hook.js:608 Warning: React does not recognize the `modalId` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `modalid` instead. If you accidentally passed it from a parent component, remove it from the DOM element. Error Component Stack

This occurred because the modalId was unintentionally included in the props passed to the modal component. I have resolved this in the PR by ensuring that modalId is excluded from the props spread onto the modal.

@rtivital rtivital merged commit 9ebe3ae into mantinedev:master Dec 12, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants