Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch avatar URLs from each website #35

Closed
jayvdb opened this issue Dec 19, 2017 · 6 comments
Closed

Fetch avatar URLs from each website #35

jayvdb opened this issue Dec 19, 2017 · 6 comments

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Dec 19, 2017

Most of the websites have some sort of avatar which can be obtained and included in the results for 'Taken' names.

This will help to see whether a username has a consistent avatar across various platforms, which can be used as a proxy to guess that they are taken by the same person.

@jayvdb jayvdb changed the title Fetch avatars from each website Show avatars from each website Dec 19, 2017
@manu-chroma
Copy link
Owner

meta property="og:image" contains image url at a lot of times. check that out

@jayvdb
Copy link
Collaborator Author

jayvdb commented Dec 19, 2017

Should we make this a backend only task to begin with?
Then you can think about the UI a bit, and then create another task to do the UI?

@manu-chroma
Copy link
Owner

Yes, that's what I had in mind.
Backend will start passing avatar links and then we can figure out the frontend part

@jayvdb jayvdb changed the title Show avatars from each website Fetch avatar URLs from each website Dec 19, 2017
@nalinbhardwaj
Copy link
Contributor

nalinbhardwaj commented Dec 20, 2017

Is there a reason to rely on metadata only? Why not add proper image fetching for valid usernames as link templates to websites.yml(and use it)
Ex. FB provides images at https://graph.facebook.com/{userid}/picture?type=square , so we just fetch from that(without relying on og:image.

@manu-chroma
Copy link
Owner

@nalinbhardwaj they're not available for all websites, but yes if we can get them, they're a better option to handle image fetch.

Apart from this, in case of fb, we'll have to extract userid from the profile source anyways to use this url.

@manu-chroma
Copy link
Owner

Might be helpful: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/summary

manu-chroma pushed a commit that referenced this issue Dec 21, 2017
Makes function get_avatar() and adds avatar related
info to websites.yml

Closes #35
@jayvdb jayvdb mentioned this issue Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants