Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test parameterisation #36

Closed
jayvdb opened this issue Dec 19, 2017 · 4 comments
Closed

Add more test parameterisation #36

jayvdb opened this issue Dec 19, 2017 · 4 comments
Labels
googlecodein

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Dec 19, 2017

#32 added pytest , however the test module still has lots of duplicated logic.

There are many advanced pytest data plugins which allow more data parameterisation that the core pytest plugins.

Implement one which removes the duplication in the test module.
@jayvdb
Copy link
Collaborator Author

jayvdb commented Dec 19, 2017

... which would have prevented copy/paste errors like #34 (comment) ;-)

This was referenced Dec 19, 2017
Merged
Merged
@jayvdb
Copy link
Collaborator Author

jayvdb commented Dec 21, 2017

The infrastructure was already added in #42, so this is now a moderately easy task, of re-applying the same approaches used there.

@seeeturtle
Copy link
Collaborator

can you assign me here?

@manu-chroma
Copy link
Owner

assigned to @seeeturtle

Make sure to get your other PR merged soon.

seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 23, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
a73c0b3 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
@seeeturtle seeeturtle mentioned this issue Dec 23, 2017
Merged
seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 24, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
0bb1802 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 25, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
28ddda1 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 25, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
30817f4 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 25, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
89528f5 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
seeeturtle added a commit to seeeturtle/username-availability-checker that referenced this issue Dec 25, 2017
@seeeturtle
test_username_api.py: Remove duplicated logic
7473310 
This will remove duplicated logic
and put into a function for each test.

Closes manu-chroma#36
manu-chroma pushed a commit that referenced this issue Dec 26, 2017
@seeeturtle @manu-chroma
test_username_api.py: Remove duplicated logic
caaf2f3 
This will remove duplicated logic
and put into a function for each test.

Closes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
googlecodein
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @manu-chroma @seeeturtle