Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weasyprint doesn't properly squash wide tables #173

Closed
vincerubinetti opened this issue Jan 29, 2019 · 2 comments
Closed

Weasyprint doesn't properly squash wide tables #173

vincerubinetti opened this issue Jan 29, 2019 · 2 comments

Comments

@vincerubinetti
Copy link
Collaborator

I just noticed that our test delete-me.md shows an error in the weasyprint export. Tables that are too wide to fit within the page simply overflow off the side. In Chrome's print to pdf this does not occur. I can't seem to specify any CSS that will fix the issue. It may have to do with weasyprint not supporting the commong word-break property, or with one of these issues:

Kozea/WeasyPrint#695
Kozea/WeasyPrint#727
Kozea/WeasyPrint#663
Kozea/WeasyPrint#541

I see that in the latest build of manubot (or pandoc?), we are using version 0.42.3 of weasyprint. Based on the above issues, it's possible that it might be fixed by switching to the latest version (0.43).

@dhimmel
Copy link
Member

dhimmel commented Jan 31, 2019

We specify the version of weasyprint at:

https://github.com/greenelab/manubot-rootstock/blob/ec359f63c7d2b9ec0f2c04fabccd648f0b6a1ab9/build/environment.yml#L31

However, there was an issue updating to 43. Let me dig this up.

Looks like v44 is now available.

Created #174, which updates to v44. I think there may be an issue with the pango version available in conda... let's see the CI.

dhimmel added a commit to dhimmel/manubot-rootstock that referenced this issue Jan 31, 2019
Updates weasyprint to v44, which may address
manubot#173
@vincerubinetti
Copy link
Collaborator Author

Closing this as it seems like we're moving away Weasy Print.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants