Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Major to depend on newer Newtonsoft.Json #131

Closed
viceice opened this issue Apr 1, 2021 · 3 comments
Closed

New Major to depend on newer Newtonsoft.Json #131

viceice opened this issue Apr 1, 2021 · 3 comments
Milestone

Comments

@viceice
Copy link

viceice commented Apr 1, 2021

Is your feature request related to a problem? Please describe.
Currently this lin depends on Json v10 and our Project depends on Json v12.
The problem is we need assembly signing and can't use binding redirects.
Our assemblies need to be deployed to the windows GAC.

Describe the solution you'd like
Release new major version which depends on Json v12 ( and v13 in a future release)

Describe alternatives you've considered
Fork this project or hook into assembly resoving / loading

Additional context
See Problem

*** Source/destination types

// not relevant

*** Source/destination JSON

{"message":"not relevant"}
@manuc66
Copy link
Owner

manuc66 commented Apr 5, 2021

It conflicts with:

@viceice
Copy link
Author

viceice commented Apr 8, 2021

I know, please do a major version bump when you change the JSON dep major version again, so the update doesn't silently pass through.

We use renovate to manage dependencies with partial automerge and automatic tests can't capture those binding issues 😕

@manuc66 manuc66 added this to the 1.9.0 milestone Sep 29, 2021
@manuc66
Copy link
Owner

manuc66 commented Sep 29, 2021

Will be the case once this will be released : #137

@manuc66 manuc66 closed this as completed Sep 29, 2021
@manuc66 manuc66 modified the milestones: 1.9.0, 2.0 Oct 22, 2021
@manuc66 manuc66 reopened this Oct 22, 2021
manuc66 added a commit that referenced this issue Sep 10, 2022
Should fix New Major to depend on newer JSON #131
@manuc66 manuc66 changed the title New Major to depend on newer JSON New Major to depend on newer Newtonsoft.Json Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants