Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileShare Support #11

Closed
wants to merge 6 commits into from
Closed

FileShare Support #11

wants to merge 6 commits into from

Conversation

manuelroemer
Copy link
Owner

New Pull Request

Prerequisites

  • All new/updated public APIs are documented via XML comments.
  • CHANGELOG.md has been updated.

Change Type

  • New Feature(s)
  • Bug Fix(es)
  • Documentation Update(s)

Description

Addresses #9.
Adds FileShare support to StorageFile.OpenAsync. The current file system implementations have support for this parameter.

Discussion

The InMemoryFileSystem only has very basic support for the FileShare. Some points for improvement are:

  • FileShare.Delete is not supported.
  • FileShare.Inheritable is not supported (and most likely never will be).
  • The file system uses independent copies of the current file content when accessed concurrently. This means that multiple readers/writers don't operate on the same content. From my side, this is fine enough right now, but it should definitely be fixed in the future.

@manuelroemer manuelroemer added the enhancement New feature or request label Jun 1, 2020
@manuelroemer manuelroemer linked an issue Jun 1, 2020 that may be closed by this pull request
Add support for FileShare when opening a file #9
Closed
@manuelroemer manuelroemer self-assigned this Jun 1, 2020
This was referenced Jun 1, 2020
Closed
Closed
Closed
@manuelroemer
Copy link
Owner Author

Closing for now. See this comment for the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manuelroemer manuelroemer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for FileShare when opening a file
1 participant
@manuelroemer