preload.mediadevices-shim: Promise returned in function argument where a void return was expected.

[manusa]

Description

The following code has been marked as a bug:

electronim/src/tab-manager/preload.mediadevices-shim.js

Lines 148 to 151 in 0ad1c68

	const updateSourcesFunction = async () => setSources(await desktopCapturer.getSources(DEFAULT_SOURCES_OPTIONS));
	useEffect(() => {
	setTimeout(updateSourcesFunction, sources ? 300 : 0);
	}, [sources]);

It should be changed to:

  const updateSourcesFunction = () => {
    desktopCapturer.getSources(DEFAULT_SOURCES_OPTIONS).then(setSources);
  };
  useEffect(() => {
    setTimeout(updateSourcesFunction, sources ? 300 : 0);
  }, [sources]);

Please note that for the tests to pass correctly, the following lines:

electronim/src/tab-manager/preload.mediadevices-shim.js

Lines 27 to 30 in 0ad1c68

	const desktopCapturer = {
	// eslint-disable-next-line no-undef
	getSources: opts => ipcRenderer.invoke(APP_EVENTS.desktopCapturerGetSources, opts)
	};

need to be changed to:

const desktopCapturer = {
  // eslint-disable-next-line no-undef
  getSources: async opts => ipcRenderer.invoke(APP_EVENTS.desktopCapturerGetSources, opts)
};

[vishnukaushik]

@manusa Could you please assign this task to me? I can work on it
Thanks!

[manusa]

sure, thx!

[vishnukaushik]

@manusa, I've raised a PR to solve this issue. Could you please take a look when you get a chance?
Thank you!