Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix WhatsApp Favicon Not Displaying Due to net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin ErrorFix/whatsapp icon #454

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

manusa
Copy link
Owner

@manusa manusa commented Dec 4, 2024

Originally authored by @lukasborges in #430

This pull request fixes the issue where the WhatsApp favicon was not displaying due to a net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin error. Previously, the favicon was applied as a background image within a div, which caused cross-origin restrictions to block it.

The solution involves:

  • Replacing the background image in the div with an tag that includes the crossorigin="anonymous" attribute to handle cross-origin restrictions.
  • Updating the CSS to explicitly set the size of the favicon by applying width: 16px and height: 16px to the image inside the tab container.

@manusa manusa force-pushed the fix/whatsapp-icon branch from defdcf7 to f3bc08f Compare December 4, 2024 06:09
@manusa manusa merged commit cb094f0 into main Dec 6, 2024
6 checks passed
@manusa manusa deleted the fix/whatsapp-icon branch December 6, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant