Skip to content
This repository has been archived by the owner on May 9, 2018. It is now read-only.

RMTileCacheDownloadOperation incorrectly checks empty source for web based tile sources #581

Closed
jefflinwood opened this issue Feb 10, 2015 · 0 comments
Closed

RMTileCacheDownloadOperation incorrectly checks empty source for web based tile sources #581

jefflinwood opened this issue Feb 10, 2015 · 0 comments

Comments

@jefflinwood
Copy link

Here's the offending line of code (_source is still nil, as the source hasn't been assigned yet)

NSAssert([_source isKindOfClass:[RMAbstractWebMapSource class]], @"only web-based tile sources are supported for downloading");

There's an easy fix, changing _source to source (to check the actual tile source being passed in)
incanus added a commit that referenced this issue Feb 19, 2015
@incanus
fixes #581: properly check for valid offline source
40ca4b4
@incanus incanus closed this as completed Feb 19, 2015
flovilmart referenced this issue in flovilmart/mapbox-ios-sdk Mar 2, 2015
@incanus @flovilmart
fixes #581: properly check for valid offline source
24cb836
albertschulz referenced this issue in albertschulz/mapbox-ios-sdk Jun 4, 2015
@incanus @albertschulz
fixes #581: properly check for valid offline source
56f8b0e
MarkSpit referenced this issue in MarkSpit/mapbox-ios-sdk Jun 16, 2015
@incanus @MarkSpit
fixes #581: properly check for valid offline source
1bfcdc4
earltedly referenced this issue in activeintime/mapbox-ios-sdk Jul 13, 2015
@earltedly
Merge branch 'release' of https://github.com/mapbox/mapbox-ios-sdk in…
f0374ea 
…to release

# By Justin R. Miller (12) and others
# Via Jason Wray (3) and others
* 'release' of https://github.com/mapbox/mapbox-ios-sdk:
  Strengthen GL language, add Swift Offline example
  update private header matches
  bump podspec version
  updated changelog for 1.6.1
  explicit public headers in podspec
  explicit module name
  podpsec formatting improvements
  refs #580: pare down Proj4 headers to barest needed for CocoaPods
  refs #580: properly find CocoaPods-based resource bundle
  Smooth edges of user location annotation icon's shadow
  ensure access token is set for v4 API access
  update link
  #578: Unrequire access token for large tiles
  fixes #601: catch bad token during development
  fixes #581: properly check for valid offline source
  Add NSLocationAlwaysUsageDescription check to assert
aleksandr-vin referenced this issue in aleksandr-vin/mapbox-ios-sdk Jul 18, 2015
@incanus @aleksandr-vin
fixes #581: properly check for valid offline source
e29eb26
@aleksandr-vin aleksandr-vin mentioned this issue Jul 19, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@incanus @jefflinwood