This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Update for Maps SDK v5.1.0 (release-oolong) #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
force-pushed
the
release-oolong-qa
branch
from
dfe707d to
11cc90a
Compare
friedbunny
force-pushed
the
release-oolong-qa
branch
from
11cc90a to
bb72307
Compare
friedbunny
force-pushed
the
release-oolong-qa
branch
from
bb72307 to
04d1a2e
Compare
friedbunny
force-pushed
the
release-oolong-qa
branch
from
04d1a2e to
0396eec
Compare
|
As of mapbox/mapbox-navigation-ios#2143, the navigation SDK is incompatible with map SDK v5.1.0. Before the navigation SDK can upgrade, we need to remove two workarounds that would result in overcorrection in v5.1.0. (This situation stems from the map SDK making backwards-incompatible changes in semver-minor releases. But at least we foresaw the problem well enough in advance that the navigation SDK could block the upgrade to v5.1.0.) |
friedbunny
approved these changes
Jun 19, 2019
Indeed! I’ve disabled the Nav SDK integration again here in 9e3356d so that this PR can merge today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working branch for QA, to be merged after the final 5.1.0 release.