Expand GeoJSON filetype detection logic #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😆 |
| @@ -23,6 +23,7 @@ function sniff(buffer, callback) { | |||
|
|
|||
| if (header.indexOf('\"tilejson\":') !== -1) return callback(null, 'tilejson'); | |||
| if ((header.indexOf('\"arcs\":') !== -1) || (header.indexOf('\"objects\":') !== -1)) return callback(null, 'topojson'); | |||
| if ((header.indexOf('\"crs\":') !== -1) || (header.indexOf('\"features\":') !== -1)) return callback(null, 'geojson'); | |||
There was a problem hiding this comment.
Just a sanity check for myself, this says "if crs OR features exists in the string, pass it on as a geojson"? Just taking a look at the TopoJSON specification, which does not specify crs anywhere, but it could be added by a user if they wanted: topojson/topojson-specification#5 - I'm not worried about this use case, though.
|
Looking good @who8mycakes! Just a little nitpicky syntax fix I mentioned for the |
|
@who8mycakes looks good to me. |
|
Staging looks 👍 . Merging! |
This was referenced Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving GeoJSON detection issues raised here:
*#44
*#35
Sniffing for
crsandfeaturesas top-level parameters before looking fortypeexpands the detection for GeoJSON file types.