Remove Static mode from the constants and use Expressions syntax in theme.js #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1077 |
This was referenced Oct 28, 2021
stepankuzmin
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Hi @oodavid! Thanks for the contribution and sorry for the delayed response. This looks good to me, especially the nicer UX 👍
However, there are 3 failing tests if I run this locally. Could you please rebase on top of the main branch and fix them, so we can merge this into the upcoming release? Thanks! 🙏
Adding for reference #435
|
Ooh, now there's a question! I'll have to jog my memory, might have the chance to take a peek tonight. |
SnailBones
approved these changes
Aug 20, 2023
stepankuzmin
force-pushed
the
bugfix-filter-modes
branch
from
dccebd3 to
25d253c
Compare
stepankuzmin
force-pushed
the
bugfix-filter-modes
branch
from
9b77743 to
f58a575
Compare
stepankuzmin
force-pushed
the
bugfix-filter-modes
branch
from
f58a575 to
3495ee5
Compare
stepankuzmin
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the following videos: