Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a clearOnClickOutside option #240

Closed
samanpwbb opened this issue Apr 6, 2019 · 1 comment · Fixed by #255
Closed

add a clearOnClickOutside option #240

samanpwbb opened this issue Apr 6, 2019 · 1 comment · Fixed by #255
Assignees
@samanpwbb

Comments

@samanpwbb
Copy link
Contributor

It would be useful to have an option that adjusts the default behavior of the geocoder to clear the input when user clicks off of the geocoder or the results list.
@samanpwbb
Copy link
Contributor Author

Clear and collapse on esc keypress would also be useful. I tried implementing this outside of the geocoder, but I think some internal event handling is preventing me from doing it well.

@samanpwbb samanpwbb self-assigned this Apr 11, 2019
samanpwbb added a commit that referenced this issue Apr 11, 2019
@samanpwbb
Add option to blur + clear on esc keypress
1ecff07 
refs #240
samanpwbb added a commit that referenced this issue Apr 11, 2019
@samanpwbb
Add option to blur + clear on esc keypress
59c4855 
refs #240
@samanpwbb samanpwbb mentioned this issue Apr 11, 2019
Merged
4 tasks
samanpwbb added a commit that referenced this issue Apr 12, 2019
@samanpwbb
add clearOnBlur option
babda70 
This option provides a more ephemeral geocoder experience, great for apps where the geocoder is a minor feature. This option works best when combined with flyTo configured with duration:0. Closes #240
@samanpwbb samanpwbb mentioned this issue Apr 12, 2019
Merged
4 tasks
samanpwbb added a commit that referenced this issue Apr 12, 2019
@samanpwbb
add clearOnBlur option
795d11a 
This option provides a more ephemeral geocoder experience, great for apps where the geocoder is a minor feature. This option works best when combined with flyTo configured with duration:0. Closes #240
samanpwbb added a commit that referenced this issue Apr 12, 2019
@samanpwbb
Add option to blur + clear on esc keypress
dbc9b9a 
refs #240
samanpwbb added a commit that referenced this issue Apr 12, 2019
@samanpwbb
add clearOnBlur option
7189b41 
This option provides a more ephemeral geocoder experience, great for apps where the geocoder is a minor feature. This option works best when combined with flyTo configured with duration:0. Closes #240
samanpwbb added a commit that referenced this issue Apr 12, 2019
@samanpwbb
add clearOnBlur option (#255)
3a888c4 
* add clearOnBlur option
This option provides a more ephemeral geocoder experience, great for apps where the geocoder is a minor feature. This option works best when combined with flyTo configured with duration:0. Closes #240
@samanpwbb samanpwbb mentioned this issue Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samanpwbb samanpwbb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add clearOnBlur option mapbox/mapbox-gl-geocoder
1 participant
@samanpwbb