Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double moveend event #229

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix double moveend event #229

merged 1 commit into from
Mar 21, 2019

Conversation

scottsfarley93
Copy link

Fixes #131 by triggering only one moveend event instead of two. Uses the same logic introduced in #218 to deduplicate result events.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • [n/a] run npm run docs and commit changes to API.md
  • [n/a] update CHANGELOG.md with changes under master heading before merging

@scottsfarley93 scottsfarley93 self-assigned this Mar 21, 2019
katydecorah
katydecorah approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@katydecorah katydecorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@scottsfarley93 scottsfarley93 merged commit 95bc8d3 into version4 Mar 21, 2019
@scottsfarley93 scottsfarley93 deleted the fix-double-moveend branch March 21, 2019 21:19
@scottsfarley93 scottsfarley93 mentioned this pull request Mar 21, 2019
Closed
@scottsfarley93 scottsfarley93 mentioned this pull request Oct 1, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katydecorah katydecorah katydecorah approved these changes

Assignees

@scottsfarley93 scottsfarley93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottsfarley93 @katydecorah