make symbol sorting more deterministic #2023
Conversation
| @@ -40,6 +40,8 @@ function SymbolBucket(options) { | |||
|
|
|||
| this.adjustedIconMaxSize = this.layer.getLayoutValue('icon-size', 18, zoomHistory); | |||
| this.adjustedIconSize = this.layer.getLayoutValue('icon-size', this.zoom + 1, zoomHistory); | |||
|
|
|||
| this.index = 0; | |||
There was a problem hiding this comment.
Could we get away with passing k to addFeature here instead? I'd prefer that to adding another class property.
There was a problem hiding this comment.
SymbolInstances for the same feature still need different values. We could do something like k * 10000 + j but that seems a bit messier.
The value doesn't need to be an index, it just needs to be a unique value we can generate the same way in both -js and -native.
I thought generating it from the position, angle and style properties but that just seems way more complicated.
There was a problem hiding this comment.
My concern isn't using the index conceptually but adding additional state to the SymbolBucket class. It's ok for the context of this PR but makes my future a little harder.
There was a problem hiding this comment.
this.symbolInstances.length should work!
|
Why subsort by index instead of x coordinate? |
Two features could have the same position but have other properties be different. You'd also have to sort by the angle and per-feature properties like text-field, icon-name and all the data-driven ones eventually. It seemed simpler to just have a counter. It doesn't need to be an index, it just needs to be unique for each instance and consistently generatable. |
|
I'm |
once 
ansis
force-pushed
the
sort-order-symbols
branch
from
45a731a to
7213285
Compare
The order of symbols with the same y value (after rotation) was undefined, which was causing some rendering differences with -native.
test-suite changes:
mapbox/mapbox-gl-test-suite@7ebad04
I'll make the same change in -native.
👀 @lucaswoj