Get and set visibleCoordinateBounds calculated differently

[TimWatson]

With contentInset set, if you tell the map to set the visible coordinate bounds to the current visible coordinate bounds the map moves since getting the visible coordinate bounds doesn't take into account the map content inset but setting it does

Get:

mapbox-gl-native/platform/ios/src/MGLMapView.mm

Line 3275 in 5733440

return [self convertRect:self.bounds toCoordinateBoundsFromView:self];

Set:

mapbox-gl-native/platform/ios/src/MGLMapView.mm

Lines 3378 to 3379 in 5733440

	mbgl::EdgeInsets padding = MGLEdgeInsetsFromNSEdgeInsets(insets);
	padding += MGLEdgeInsetsFromNSEdgeInsets(self.contentInset);

Steps to reproduce

1. Set mapView.contentInset = UIEdgeInsets(top: 50, left: 10, bottom: 100, right: 10)
2. Call mapView.setVisibleCoordinateBounds(mapView.visibleCoordinateBounds)
3. Map jumps to different region

Expected behavior

Get visible coordinate bounds would take into account content inset and the map would stay put

Corrected Get:
return [self convertRect:self.bounds.inset(by: self.contentInset) toCoordinateBoundsFromView:self];

Actual behavior

Map jumps to different region

Configuration

Mapbox SDK versions: ios-v4.9.0
iOS/macOS versions: iOS 12.1.4
Device/simulator models: iPhoneX
Xcode version: 10.1

[stale]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.