Use contentInset for visibleCoordinateBounds

[TimWatson]

Fix for #14134

[1ec5]

While you’re at it, the macOS implementation of MGLMapView.visibleCoordinateBounds also needs the same fix:

mapbox-gl-native/platform/macos/src/MGLMapView.mm

Lines 1285 to 1287 in 41b25e2

	- (MGLCoordinateBounds)visibleCoordinateBounds {
	return [self convertRect:self.bounds toCoordinateBoundsFromView:self];
	}

[TimWatson]

Any idea why these tests are failing? Is there something else I need to do before this gets merged?

[friedbunny]

Thanks for your patience, @TimWatson.

iOS

The ios-release build is failing because of #14345, which is inconvenient but doesn’t indicate an issue with this PR. I’ll push a copy of your branch here and the build should run.

Though your change seems confined, I’d be worried that it will have knock-on effects — in order to merge this, we’ll need to be confident that it’s well tested and has no unforeseen consequences. To run the iOS Maps SDK’s tests locally, see these instructions.

macOS

The macOS build is failing because UIEdgeInsetsInsetRect doesn’t exist in AppKit:

❌  /platform/macos/src/MGLMapView.mm:1293:30: use of undeclared identifier ‘UIEdgeInsetsInsetRect’

To make changes to the macOS project, run make xproj and Xcode will open to the correct environment.

[TimWatson]

Thanks @friedbunny

I fixed the issues with macOS

[friedbunny]

There’s been a fair bit of work done on this recently (#14664, #14795, #14813, etc.) — is this still valid, @fabian-guerra @astojilj?

[stale]

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.