Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] [WIP] Create snapshot wrapper #10048

Closed
wants to merge 3 commits into from
Closed

[android] [WIP] Create snapshot wrapper #10048

wants to merge 3 commits into from

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 added Android Mapbox Maps SDK for Android in progress ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Sep 22, 2017
@Guardiola31337 Guardiola31337 self-assigned this Sep 22, 2017
ivovandongen
ivovandongen reviewed Sep 25, 2017
View reviewed changes
Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be simplified a bit. Since the Bitmap is wrapped in a Snapshot in MapSnapshotter#onSnapshotReady why do we need to change anything on the c++ side?

Don't we have all the information needed in the MapSnapshotter on the jvm side?

@Guardiola31337 Guardiola31337 added this to the android-v5.2.0 milestone Sep 25, 2017
@tobrun
Copy link
Member

tobrun commented Oct 13, 2017

work is being continued in #10163

@tobrun tobrun closed this Oct 13, 2017
@Guardiola31337 Guardiola31337 deleted the pg-snapshot-wrapper branch October 13, 2017 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivovandongen ivovandongen ivovandongen left review comments

@tobrun tobrun Awaiting requested review from tobrun

Assignees

@Guardiola31337 Guardiola31337

Labels
Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold
Projects
None yet
Milestone
android-v5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Guardiola31337 @tobrun @ivovandongen