This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Provide a fallback method to load the native library #10154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Oct 9, 2017
| */ | ||
| public static void load() { | ||
| System.loadLibrary("mapbox-gl"); | ||
| public static void load(Context context) { |
There was a problem hiding this comment.
we could keep the signature of this the same if we replace the context below with Mapbox.getApplicationContext()?
There was a problem hiding this comment.
Good idea. I did that with 1d4c675, I'll merge it once CI gives the blessing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
LibraryLoaderto provide an alternative location for the native library. This location, in the app's internal storage, is exposed via a newgetLibraryLocation()method.Note that this new codepath doesn't change the current behavior:
System.loadLibrary()continues to be the default and preferred way to loadlibmapbox-gl.so.