This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] add content inset to camera edge padding #14081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
added
bug
iOS
julianrex
approved these changes
Mar 11, 2019
1ec5
suggested changes
Mar 19, 2019
| mbgl::CameraOptions cameraOptions = [self cameraOptionsObjectForAnimatingToCamera:camera edgePadding:edgePadding]; | ||
|
|
||
| mbgl::EdgeInsets padding = MGLEdgeInsetsFromNSEdgeInsets(edgePadding); | ||
| padding += MGLEdgeInsetsFromNSEdgeInsets(self.contentInset); |
There was a problem hiding this comment.
Some callers are already adding the same content inset to the padding:
mapbox-gl-native/platform/ios/src/MGLMapView.mm
Line 3757 in d00d296
To avoid the redundant change, those callers also need to be updated.
|
I haven't been able to figure out how to write a test for this case yet. Edge padding is thrown away after transform_state is finished. Perhaps a snapshot test could work. Any ideas are very much welcome. |
|
Is this still valid? |
|
Indeed, there’s been a fair bit of work done on this recently (#14664, #14795, #14813, etc.) — is this still valid, @fabian-guerra @astojilj? |
|
This was fixed in #14813 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12818
For consistency with other camera methods,
-[MGLMapView setCamera:withDuration:animationTimingFunction:edgePadding:completionHandler:]now adds thecontentInsetto the edge padding when updating the camera.cc @fabian-guerra @julianrex @1ec5