This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add resource usage to HttpRequest, add offline query param #14837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Jun 4, 2019
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/http/HttpRequestUrl.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-offline-flag
branch
2 times, most recently
from
e893622 to
0693e8e
Compare
tobrun
commented
Jun 4, 2019
|
iOS landed in #14857, this PR is ready for review. |
zugaldia
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Should https://github.com/mapbox/mapbox-gl-native/pull/14837/files#r290383265 be addressed before merging? otherwise LGTM. Also note that the PR is still marked as draft.
…meter flag to http request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14819
Add resource usage to HttpRequest, add offline query parameter to HttpRequest.
This PR remains in draft until we have a PR open for iOS
cc @julianrex