[core] Fix using in expression with filter

[Chaoba]

Resolves #16262
mbgl::style::conversion::isExpression() always returns false for expression in, this PR fix this issue.

The test in added in android test app in this pr: mapbox/mapbox-gl-native-android#218

I'm not sure where should add test cases for this change, @alexshalamov any suggestions for it?

[1ec5]

Suggested changelog entry:

• Fixed an issue where in expressions were interpreted as legacy filters.

[1ec5]

I'm not sure where should add test cases for this change

mapbox/mapbox-gl-js#9374 adds relevant test cases to the style specification unit tests. Would it be feasible to update the submodule to include that change?

[alexshalamov]

@Chaoba PR looks good, could you add render test for that in gl-js? Something similar to an example in #16262

[1ec5]

Unfortunately, rendering tests are now failing due to updating the GL JS submodule, which brought in a test case for mapbox/mapbox-gl-js#9198 along with the test case for mapbox/mapbox-gl-js#9374 that we wanted.

[alexshalamov]

Unfortunately, rendering tests are now failing due to updating the GL JS submodule, which brought in a test case for mapbox/mapbox-gl-js#9198

@Chaoba could you please add failing tests related to mapbox/mapbox-gl-js#9198 test/integration/query-tests/evaluated/* to ignore list https://github.com/mapbox/mapbox-gl-native/blob/master/metrics/ignores/platform-all.json

[Chaoba]

@Chaoba PR looks good, could you add render test for that in gl-js? Something similar to an example in #16262

@alexshalamov Created a ticket in gl-js to track it.

[Chaoba]

@alexshalamov I didn't change these files, why sanity-checks failed?

[Chaoba]

The issue in this pr is that:

1. If we update gl-js, the nitpick will fail.
2. If we apply nitpick patch, then the test case will fail

2: [ RUN      ] Annotations.DebugSparse
2: ../test/src/mbgl/test/util.cpp:49: Failure
2: Expected: (pixels / (expected.size.width * expected.size.height)) <= (imageThreshold), actual: 0.015564 vs 0.0002
2: [  FAILED  ] Annotations.DebugSparse (103 ms)

@tmpsantos What should we do to let this pr merged?

[alexshalamov]

lgtm, please remove gl-js bump commit and rebase to master

[1ec5]

The failing test came in through mapbox/mapbox-gl-js#9397 as a result of #16293, which has landed. It should pass once you rebase this branch onto master.

[chloekraw]

@tmpsantos thanks for rebasing! CI is passing, good to merge?

[chloekraw]

Ack, forgot the changelog. @Chaoba would you mind adding an entry in a separate pr?

[pozdnyakov]

Change log entry proposal

### Bugs

Fixed using of the `in` expression as a layer filter ([#16272](https://github.com/mapbox/mapbox-gl-native/pull/16272))

The bug was caused by `mbgl::style::conversion::isExpression()` always returning `false` for the `in` expression.