This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Don't use depth test unless text is pitch-aligned to map #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yhahn, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @ansis and @artemp to be potential reviewers. |
yhahn
force-pushed
the
viewport-symbol-nodepth
branch
2 times, most recently
from
8d1c5c0 to
6eb5dd2
Compare
yhahn
force-pushed
the
viewport-symbol-nodepth
branch
from
5c425e5 to
b022562
Compare
yhahn
changed the title
Merged
5 tasks
jfirebaugh
approved these changes
Sep 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing the stopgap fix for a viewport-oriented clipped text bug, similar to issue reported in mapbox/mapbox-gl-js#2074 (comment) for GL JS but in the context of viewport pitched labels.
cc @ansis