Changed the elevation of the InstructionView so that it doesn't encounter overlapping issues. #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
2e8abf7 to
92c87c8
Compare
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
92c87c8 to
cc6dd29
Compare
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
2 times, most recently
from
9736222 to
f12369e
Compare
devotaaabel
changed the title
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
2 times, most recently
from
51a3d8b to
9e79d17
Compare
|
@danesfeder ready for re-review |
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
9e79d17 to
a4b2978
Compare
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
a4b2978 to
012e9a2
Compare
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
012e9a2 to
12a764c
Compare
akitchen
added
the
needs discussion
devotaaabel
removed
the
needs discussion
…it is always on top of the rest of the view
devotaaabel
force-pushed
the
devota-update-instruction-view-layer
branch
from
12a764c to
7414f15
Compare
danesfeder
approved these changes
Nov 14, 2018
| @@ -494,6 +495,7 @@ private void initializeView() { | |||
| private void bind() { | |||
| mapView = findViewById(R.id.navigationMapView); | |||
| instructionView = findViewById(R.id.instructionView); | |||
| ViewCompat.setElevation(instructionView, 10); | |||
There was a problem hiding this comment.
Have we considered extracting the magic number 10 into a constant specifying that this is actually putting the instructionView at the top of the view hierarchy?
|
@devotaaabel feel free to address @Guardiola31337's comment / merge this when you have a chance |
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
===========================================
+ Coverage 23.68% 23.7% +0.01%
Complexity 735 735
===========================================
Files 194 194
Lines 8291 8286 -5
Branches 608 607 -1
===========================================
Hits 1964 1964
+ Misses 6142 6137 -5
Partials 185 185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1072