Change feedback timing #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
reviewed
Oct 30, 2017
| @@ -123,7 +123,7 @@ private void initCountDownAnimation() { | |||
| ObjectAnimator countdownAnimation = ObjectAnimator.ofInt(feedbackProgressBar, | |||
| "progress", 0); | |||
| countdownAnimation.setInterpolator(new LinearInterpolator()); | |||
| countdownAnimation.setDuration(5000); | |||
| countdownAnimation.setDuration(10000); | |||
There was a problem hiding this comment.
Maybe just pull this value out as a constant and later allow users to customize it?
There was a problem hiding this comment.
@cammace added the ability to adjust this when creating a new instance
cammace
approved these changes
Oct 31, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Nov 2, 2017
* cam-upgrade-project: Changed location engine imports changed to 0.2 location layer version fixes ordering of the bearings (mapbox#455) Updated Maneuver Icons (mapbox#445) Change feedback timing (mapbox#442) changed apk filepath changed sonarqube version to work with gradle 3.0 fixed a few test issues upgraded to gradle 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ericrwolfe